Issue #98: Fix packaging configuration to include all subdirectories#99
Merged
Subterrane merged 2 commits intoonelogin:mainfrom Sep 2, 2025
Merged
Issue #98: Fix packaging configuration to include all subdirectories#99Subterrane merged 2 commits intoonelogin:mainfrom
Subterrane merged 2 commits intoonelogin:mainfrom
Conversation
- Change packages = ["onelogin"] to packages = {find = {}}
- This ensures onelogin.api and onelogin.models are included in the package
- Fixes ImportError: No module named 'onelogin.api'
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a packaging configuration issue that was causing import errors for the onelogin library's subdirectories. The change updates the setuptools configuration to automatically discover and include all packages rather than explicitly listing only the top-level package.
- Updates setuptools package discovery from explicit listing to automatic discovery
- Ensures all subdirectories (onelogin.api, onelogin.models) are included in the package build
- Resolves ImportError issues when trying to import submodules
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves issue #98. I don't have a Jira ticket number, I'm not sure where to get that.
This pull request updates the packaging configuration in
pyproject.tomlto improve how packages are discovered and included. The change ensures that only relevant source code is packaged, excluding test and documentation directories.Packaging improvements:
packagessetting to usefindand explicitly excludetests*anddocs*directories from the package distribution, ensuring a cleaner package and reducing unnecessary files in releases.